rohangarg commented on code in PR #13475:
URL: https://github.com/apache/druid/pull/13475#discussion_r1038043825
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerSketchFetcher.java:
##########
@@ -155,7 +152,17 @@ CompletableFuture<Either<Long, ClusterByPartitions>>
inMemoryFullSketchMerging(
mergedStatisticsCollector.clear();
}
}
- });
+ }));
+ });
+
+ partitionFuture.whenComplete((result, exception) -> {
Review Comment:
Also, is it necessary to cancel the pending/running futures? It would be
incase we'll be retrying the stats collection stage - otherwise if we're going
to fail the whole job, it is not necessary to fail them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
