imply-cheddar commented on code in PR #13458:
URL: https://github.com/apache/druid/pull/13458#discussion_r1039300219
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java:
##########
@@ -258,13 +273,33 @@ public static DruidQuery fromPartialQuery(
sorting = null;
}
+ if (partialQuery.getWindow() != null) {
+ final QueryContext queryContext = plannerContext.queryContext();
+ if (queryContext.getBoolean("windowsAreForClosers", false)) {
+ windowing = Preconditions.checkNotNull(
+ Windowing.fromCalciteStuff(
+ partialQuery,
+ plannerContext,
+ sourceRowSignature, // TODO(gianm): window can only apply to
the source data, because SCAN -> WINDOW
+ rexBuilder
+ )
+ );
+ } else {
+ plannerContext.setPlanningError("Windowing Not Currently Supported");
Review Comment:
Agree, going to claim out-of-scope for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
