churromorales opened a new pull request, #13498:
URL: https://github.com/apache/druid/pull/13498

   Should address: https://github.com/apache/druid/issues/5709
   
   This is a problem we experienced.  When nodes go down unexpectedly, queries 
in flight will fail.  We want druid to retry these segments for the failed 
historicals since we have replication > 1.  
   
   This adds missing segments to the context when a channel disconnect happens 
so the RetryQueryRunner can make the query.  
   
   I wanted to put up this PR and get some eyes on it first as testing this is 
a bit tricky so I will have to do a bit of refactoring.  Before I go down the 
refactoring path, I want to make sure I'm not doing something outlandish.  If 
this looks good to folks, I can try and add some tests. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to