This is an automated email from the ASF dual-hosted git repository.
gian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new fda0a1aadd Set chatAsync default to true. (#13491)
fda0a1aadd is described below
commit fda0a1aadde9d640cd4f9ff448a74ee5d2149d2a
Author: Gian Merlino <[email protected]>
AuthorDate: Mon Dec 5 20:53:59 2022 -0800
Set chatAsync default to true. (#13491)
This functionality was originally added in #13354.
---
docs/development/extensions-core/kafka-supervisor-reference.md | 4 ++--
docs/development/extensions-core/kinesis-ingestion.md | 4 ++--
.../supervisor/SeekableStreamSupervisorTuningConfig.java | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/development/extensions-core/kafka-supervisor-reference.md
b/docs/development/extensions-core/kafka-supervisor-reference.md
index 9dc80d0c65..360e75a83d 100644
--- a/docs/development/extensions-core/kafka-supervisor-reference.md
+++ b/docs/development/extensions-core/kafka-supervisor-reference.md
@@ -204,8 +204,8 @@ The `tuningConfig` is optional and default parameters will
be used if no `tuning
| `handoffConditionTimeout` | Long | Milliseconds to wait
for segment handoff. It must be >= 0, where 0 means to wait forever.
[...]
| `resetOffsetAutomatically` | Boolean | Controls behavior when
Druid needs to read Kafka messages that are no longer available (i.e. when
`OffsetOutOfRangeException` is encountered).<br/><br/>If false, the exception
will bubble up, which will cause your tasks to fail and ingestion to halt. If
this occurs, manual intervention is required to correct the situation;
potentially using the [Reset Supervisor
API](../../operations/api-reference.md#supervisors). This mode is useful [...]
| `workerThreads` | Integer | The number of threads
that the supervisor uses to handle requests/responses for worker tasks, along
with any other internal asynchronous operation.
[...]
-| `chatAsync` | Boolean | If true, use
asynchronous communication with indexing tasks, and ignore the `chatThreads`
parameter. If false, use synchronous communication in a thread pool of size
`chatThreads`.
[...]
-| `chatThreads` | Integer | The number of threads
that will be used for communicating with indexing tasks. Ignored if `chatAsync`
is `true`.
[...]
+| `chatAsync` | Boolean | If true, use
asynchronous communication with indexing tasks, and ignore the `chatThreads`
parameter. If false, use synchronous communication in a thread pool of size
`chatThreads`.
[...]
+| `chatThreads` | Integer | The number of threads
that will be used for communicating with indexing tasks. Ignored if `chatAsync`
is `true` (the default).
[...]
| `chatRetries` | Integer | The number of times
HTTP requests to indexing tasks will be retried before considering tasks
unresponsive.
[...]
| `httpTimeout` | ISO8601 Period | How long to wait for a
HTTP response from an indexing task.
[...]
| `shutdownTimeout` | ISO8601 Period | How long to wait for
the supervisor to attempt a graceful shutdown of tasks before exiting.
[...]
diff --git a/docs/development/extensions-core/kinesis-ingestion.md
b/docs/development/extensions-core/kinesis-ingestion.md
index 31682b54a2..9b14ec767c 100644
--- a/docs/development/extensions-core/kinesis-ingestion.md
+++ b/docs/development/extensions-core/kinesis-ingestion.md
@@ -291,8 +291,8 @@ The `tuningConfig` is optional. If no `tuningConfig` is
specified, default param
|`resetOffsetAutomatically`|Boolean|Controls behavior when Druid needs to read
Kinesis messages that are no longer available.<br/><br/>If false, the exception
will bubble up, which will cause your tasks to fail and ingestion to halt. If
this occurs, manual intervention is required to correct the situation;
potentially using the [Reset Supervisor
API](../../operations/api-reference.md#supervisors). This mode is useful for
production, since it will make you aware of issues with ingestion.< [...]
|`skipSequenceNumberAvailabilityCheck`|Boolean|Whether to enable checking if
the current sequence number is still available in a particular Kinesis shard.
If set to false, the indexing task will attempt to reset the current sequence
number (or not), depending on the value of `resetOffsetAutomatically`.|no
(default == false)|
|`workerThreads`|Integer|The number of threads that the supervisor uses to
handle requests/responses for worker tasks, along with any other internal
asynchronous operation.|no (default == min(10, taskCount))|
-|`chatAsync`|Boolean| If true, use asynchronous communication with indexing
tasks, and ignore the `chatThreads` parameter. If false, use synchronous
communication in a thread pool of size `chatThreads`.
[...]
-|`chatThreads`|Integer| The number of threads that will be used for
communicating with indexing tasks. Ignored if `chatAsync` is `true`.| no
(default == min(10, taskCount * replicas))|
+|`chatAsync`|Boolean| If true, use asynchronous communication with indexing
tasks, and ignore the `chatThreads` parameter. If false, use synchronous
communication in a thread pool of size `chatThreads`.
[...]
+|`chatThreads`|Integer| The number of threads that will be used for
communicating with indexing tasks. Ignored if `chatAsync` is `true` (the
default).| no (default == min(10, taskCount * replicas))|
|`chatRetries`|Integer|The number of times HTTP requests to indexing tasks
will be retried before considering tasks unresponsive.| no (default == 8)|
|`httpTimeout`|ISO8601 Period|How long to wait for a HTTP response from an
indexing task.|no (default == PT10S)|
|`shutdownTimeout`|ISO8601 Period|How long to wait for the supervisor to
attempt a graceful shutdown of tasks before exiting.|no (default == PT80S)|
diff --git
a/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorTuningConfig.java
b/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorTuningConfig.java
index c74c2952de..c518887cfb 100644
---
a/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorTuningConfig.java
+++
b/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorTuningConfig.java
@@ -26,7 +26,7 @@ import org.joda.time.Period;
public interface SeekableStreamSupervisorTuningConfig
{
- boolean DEFAULT_ASYNC = false;
+ boolean DEFAULT_ASYNC = true;
String DEFAULT_OFFSET_FETCH_PERIOD = "PT30S";
int DEFAULT_CHAT_RETRIES = 8;
String DEFAULT_HTTP_TIMEOUT = "PT10S";
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
