imply-cheddar commented on code in PR #13458:
URL: https://github.com/apache/druid/pull/13458#discussion_r1040606467
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/PartialDruidQuery.java:
##########
@@ -388,16 +388,14 @@ public boolean canAccept(final Stage stage)
} else if (stage.compareTo(currentStage) <= 0) {
// Cannot go backwards.
return false;
- } else if (stage.compareTo(Stage.AGGREGATE) > 0 &&
stage.compareTo(Stage.SORT) < 0 && aggregate == null) {
- // Cannot do post-aggregation stages without an aggregation.
- return false;
- } else if (stage.compareTo(Stage.SORT) > 0 && sort == null) {
- // Cannot do post-sort stages without a sort.
- return false;
- } else {
+ } else // Cannot do post-sort stages without a sort.
Review Comment:
YEah, looks like it re-wrote the final one to actually just return instead
of be a branch and then had a hard time with the comments...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
