kfaraz commented on PR #13503: URL: https://github.com/apache/druid/pull/13503#issuecomment-1338936574
Thanks a lot for the feedback, @gianm ! I have made the following changes: - Limited max batch size to 500 - Updated links and docs based on feedback - Added doc about `segmentTransactionalInsert` and removed doc of `segmentInsert`. - A `segmentInsert` action always translates to a `segmentTransactionInsert` action (see snippet below). It was being used only in the `TaskToolbox`. I have updated this usage. I wonder if we should just deprecate and remove the `segmentInsert` action. Please let me know if the changes make sense. https://github.com/apache/druid/blob/136322d13b68f1e14552ea606ac70101ff6af400/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentInsertAction.java#L71-L75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
