kfaraz commented on code in PR #13508:
URL: https://github.com/apache/druid/pull/13508#discussion_r1040814081


##########
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/theta/sql/ThetaSketchSetBaseOperatorConversion.java:
##########
@@ -63,6 +63,8 @@ public DruidExpression toDruidExpression(
       RexNode rexNode
   )
   {
+    plannerContext.setPlanningError("%s can only be used on aggregates. " +
+        "It cannot be used directly on a column or or on a scalar 
expression.", getFunctionName());

Review Comment:
   typo: double `or`
   
   Since the error message is specific to theta sketch, maybe we can mention 
the exact type of arguments this function expects, rather than mentioning what 
it cannot accept.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to