imply-cheddar commented on code in PR #13519: URL: https://github.com/apache/druid/pull/13519#discussion_r1042037279
########## core/src/main/java/org/apache/druid/java/util/common/parsers/FlattenerJsonProvider.java: ########## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.java.util.common.parsers; + +import com.jayway.jsonpath.InvalidJsonException; +import com.jayway.jsonpath.spi.json.JsonProvider; + +import java.io.InputStream; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +public abstract class FlattenerJsonProvider implements JsonProvider +{ + @Override + public Object createArray() + { + return new ArrayList<>(); + } + + @Override + public Object createMap() + { + return new HashMap<>(); Review Comment: Nit: LinkedHashMaps are nicer 'cause they maintain order on iteration. This makes things a lot nicer for like, `toString()` and other debug-style activities. ########## extensions-core/protobuf-extensions/src/main/java/org/apache/druid/data/input/protobuf/ProtobufConverter.java: ########## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.data.input.protobuf; + +import com.google.common.collect.Lists; +import com.google.common.collect.Maps; +import com.google.protobuf.Any; +import com.google.protobuf.BoolValue; +import com.google.protobuf.ByteString; +import com.google.protobuf.BytesValue; +import com.google.protobuf.Descriptors; +import com.google.protobuf.DoubleValue; +import com.google.protobuf.Duration; +import com.google.protobuf.FieldMask; +import com.google.protobuf.FloatValue; +import com.google.protobuf.Int32Value; +import com.google.protobuf.Int64Value; +import com.google.protobuf.InvalidProtocolBufferException; +import com.google.protobuf.ListValue; +import com.google.protobuf.Message; +import com.google.protobuf.StringValue; +import com.google.protobuf.Struct; +import com.google.protobuf.Timestamp; +import com.google.protobuf.UInt32Value; +import com.google.protobuf.UInt64Value; +import com.google.protobuf.Value; +import com.google.protobuf.util.Durations; +import com.google.protobuf.util.FieldMaskUtil; +import com.google.protobuf.util.JsonFormat; +import com.google.protobuf.util.Timestamps; + +import javax.annotation.Nonnull; +import javax.annotation.Nullable; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +/** + * Convert {@link Message} to plain java stuffs, based roughly on the conversions done with {@link JsonFormat} + */ +public class ProtobufConverter +{ + private static final Map<String, SpecializedConverter> SPECIAL_CONVERSIONS = buildSpecializedConversions(); + + @Nullable + public static Map<String, Object> convertMessage(Message msg) throws InvalidProtocolBufferException + { + if (msg == null) { + return null; + } + final Map<Descriptors.FieldDescriptor, Object> fields = msg.getAllFields(); + final Map<String, Object> converted = Maps.newHashMapWithExpectedSize(fields.size()); + for (Map.Entry<Descriptors.FieldDescriptor, Object> field : fields.entrySet()) { + converted.put(field.getKey().getJsonName(), convertField(field.getKey(), field.getValue())); + } + return converted; + } + + @Nullable + private static Object convertField(Descriptors.FieldDescriptor field, Object value) + throws InvalidProtocolBufferException + { + // handle special types + if (value instanceof Message) { + Message msg = (Message) value; + final String typeName = msg.getDescriptorForType().getFullName(); + SpecializedConverter converter = SPECIAL_CONVERSIONS.get(typeName); + if (converter != null) { + return converter.convert(msg); + } + } + + if (field.isMapField()) { + return convertMap(field, value); + } else if (field.isRepeated()) { + return convertList(field, (List<?>) value); + } else { + return convertSingleValue(field, value); + } + } + + @Nonnull + private static List<Object> convertList(Descriptors.FieldDescriptor field, List<?> value) + throws InvalidProtocolBufferException + { + final List<Object> theList = Lists.newArrayListWithExpectedSize(value.size()); + for (Object element : value) { + theList.add(convertSingleValue(field, element)); + } + return theList; + } + + @Nullable + private static Object convertMap(Descriptors.FieldDescriptor field, Object value) + throws InvalidProtocolBufferException + { + final Descriptors.Descriptor type = field.getMessageType(); + final Descriptors.FieldDescriptor keyField = type.findFieldByName("key"); + final Descriptors.FieldDescriptor valueField = type.findFieldByName("value"); + if (keyField == null || valueField == null) { + throw new InvalidProtocolBufferException("Invalid map field."); + } + + @SuppressWarnings("unchecked") + final List<Object> elements = (List<Object>) value; + final HashMap<String, Object> theMap = Maps.newHashMapWithExpectedSize(elements.size()); + for (Object element : elements) { + Message entry = (Message) element; + theMap.put( + (String) convertSingleValue(keyField, entry.getField(keyField)), + convertSingleValue(valueField, entry.getField(valueField)) + ); + } + return theMap; + } + + @Nullable + private static Object convertSingleValue(Descriptors.FieldDescriptor field, Object value) + throws InvalidProtocolBufferException + { + switch (field.getType()) { + case BYTES: + return ((ByteString) value).toByteArray(); + case ENUM: + // Special-case google.protobuf.NullValue (it's an Enum). + if (field.getEnumType().getFullName().equals("google.protobuf.NullValue")) { Review Comment: Is String equality really the best way? If it is, do it as `"google.protobuf...".equals()` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
