[GitHub] [druid] vogievetsky opened a new pull request, #13523: Web console: improve compaction status display

[GitBox]

vogievetsky opened a new pull request, #13523:
URL: https://github.com/apache/druid/pull/13523

   This PR is attempting to resolve a UX confusion.
   
   The issue: sometimes the datasources tab shows a datasource to be "Fully 
compacted" when in fact there are segments that should be compacted. I believe 
that the cause of this (or at least one of the causes) is that there are 
segments in the "skipOffsetFromLatest" interval and the user does not realize 
that they are getting skipped (by design).
   
   Solution, if there are skipped segments, instead of rendering the status as 
"Fully compacted" render it as "Fully compacted (except the last P1D of data, 
24 segments skipped)` where P1D is the skipOffsetFromLatest setting and 24 is 
the number of segments skipped. This simply makes the label more truthful and 
potentially less confusing.
   
   Before:
   
   <img width="1589" alt="image" 
src="https://user-images.githubusercontent.com/177816/206285070-48ccfcdf-3b0c-49e9-8deb-34c246d3d122.png";>
   
   After:
   
   <img width="1594" alt="image" 
src="https://user-images.githubusercontent.com/177816/206285109-1ec18cf8-7c31-4ba7-ae80-a46e1f9cd81e.png";>
   
   After with expanded column:
   
   <img width="1598" alt="image" 
src="https://user-images.githubusercontent.com/177816/206285196-27c18926-d6be-4479-b63f-88d781c6e750.png";>
   
   The column width of the `Compaction` column has been expanded slightly to 
accommodate as tantalizing `(except...`
   
   I believe this change is a no-op since all these properties would be zero or 
non-zero together but it does not hurt to be more robust:
   
   <img width="1382" alt="image" 
src="https://user-images.githubusercontent.com/177816/206285736-01fbda58-f424-4102-9311-a94e3cebd15d.png";>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org