digitalpoetry commented on code in PR #13539:
URL: https://github.com/apache/druid/pull/13539#discussion_r1044385561
##########
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisIndexTaskIOConfig.java:
##########
@@ -33,12 +35,23 @@
public class KinesisIndexTaskIOConfig extends
SeekableStreamIndexTaskIOConfig<String, String>
{
- public static final int DEFAULT_RECORDS_PER_FETCH = 4000;
public static final int DEFAULT_FETCH_DELAY_MILLIS = 0;
+ /**
+ * Together with {@link
KinesisIndexTaskTuningConfig#MAX_RECORD_BUFFER_MEMORY}, don't take up more than
200MB
+ * per task.
+ */
+ private static final int MAX_RECORD_FETCH_MEMORY = 100_000_000;
+
+ /**
+ * Together with {@link
KinesisIndexTaskTuningConfig#RECORD_BUFFER_MEMORY_MAX_HEAP_FRACTION}, don't
take up more
+ * than 15% of the heap.
+ */
+ private static final double RECORD_FETCH_MEMORY_MAX_HEAP_FRACTION = 0.05;
Review Comment:
I believe the intention here is that `RECORD_BUFFER_MEMORY_MAX_HEAP_FRACTION
+ RECORD_FETCH_MEMORY_MAX_HEAP_FRACTION` makes up the 15% threshold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
