[druid] branch master updated: Removing unused exec service. (#13541)

[kfaraz]

This is an automated email from the ASF dual-hosted git repository.

kfaraz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git


The following commit(s) were added to refs/heads/master by this push:
     new 5a3d79a5d5 Removing unused exec service. (#13541)
5a3d79a5d5 is described below

commit 5a3d79a5d5612eb91aa6d8df57024aa60fc457ff
Author: Karan Kumar <karankumar1...@gmail.com>
AuthorDate: Mon Dec 12 14:39:42 2022 +0530

    Removing unused exec service. (#13541)
---
 .../apache/druid/msq/indexing/MSQControllerTask.java    | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git 
a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java
 
b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java
index 76d079348b..9e59f6c625 100644
--- 
a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java
+++ 
b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java
@@ -38,12 +38,10 @@ import org.apache.druid.indexing.common.task.AbstractTask;
 import org.apache.druid.indexing.common.task.Tasks;
 import org.apache.druid.java.util.common.ISE;
 import org.apache.druid.java.util.common.StringUtils;
-import org.apache.druid.java.util.common.concurrent.Execs;
 import org.apache.druid.msq.exec.Controller;
 import org.apache.druid.msq.exec.ControllerContext;
 import org.apache.druid.msq.exec.ControllerImpl;
 import org.apache.druid.msq.exec.MSQTasks;
-import org.apache.druid.msq.util.MultiStageQueryContext;
 import org.apache.druid.rpc.ServiceClientFactory;
 import org.apache.druid.rpc.StandardRetryPolicy;
 import org.apache.druid.rpc.indexing.OverlordClient;
@@ -52,8 +50,6 @@ import org.joda.time.Interval;
 import javax.annotation.Nullable;
 import java.util.List;
 import java.util.Map;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
 
 @JsonTypeName(MSQControllerTask.TYPE)
 public class MSQControllerTask extends AbstractTask
@@ -74,8 +70,6 @@ public class MSQControllerTask extends AbstractTask
   // Enables users, and the web console, to see the original SQL type names 
(if any). Not used by any other Druid logic.
   @Nullable
   private final List<String> sqlTypeNames;
-  @Nullable
-  private final ExecutorService remoteFetchExecutorService;
 
   // Using an Injector directly because tasks do not have a way to provide 
their own Guice modules.
   @JacksonInject
@@ -106,13 +100,6 @@ public class MSQControllerTask extends AbstractTask
     this.sqlQueryContext = sqlQueryContext;
     this.sqlTypeNames = sqlTypeNames;
 
-    if 
(MultiStageQueryContext.isDurableStorageEnabled(querySpec.getQuery().context()))
 {
-      this.remoteFetchExecutorService =
-          Executors.newCachedThreadPool(Execs.makeThreadFactory(getId() + 
"-remote-fetcher-%d"));
-    } else {
-      this.remoteFetchExecutorService = null;
-    }
-
     addToContext(Tasks.FORCE_TIME_CHUNK_LOCK_KEY, true);
   }
 
@@ -198,10 +185,6 @@ public class MSQControllerTask extends AbstractTask
     if (controller != null) {
       controller.stopGracefully();
     }
-    if (remoteFetchExecutorService != null) {
-      // This is to make sure we don't leak connections.
-      remoteFetchExecutorService.shutdownNow();
-    }
   }
 
   @Override


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org