rohangarg commented on PR #13553: URL: https://github.com/apache/druid/pull/13553#issuecomment-1350953682
> The one draw-back to the copy-and-edit approach is that each Calcite upgrade requires a manual step to match up our version against the new Calcite version, and to understand the difference between any Calcite changes and our own. The edit script was meant to automate that process. But, it is fine to make it a manual process, since we seldom upgrade Calcite. (Note, however, that there is an open PR to do just that: to upgrade Calcite.) I was thinking that manual checking of conflicts also provides value since it would help in catching them ahead of time instead of logical conflicts staying the code and failing later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
