kfaraz commented on PR #13559: URL: https://github.com/apache/druid/pull/13559#issuecomment-1352914412
Added some more validations for SELECT and REPLACE. The bytes are currently being validated in tests only for external input, not for segment input. To validate bytes read from the segment, the following things might need to be done: - `QueryableIndex` could expose a `getSize()` - the segments created during the initial setup of `SqlTestFramework.createQuerySegmentWalker()` could be reused in the `MSQTestBase.getSupplierForSegment()` - the corresponding `DataSegment` objects should be retained in the `BaseCalciteQueryTest` to be used for expected size. Since doing all of this would be outside the scope of this PR, we can address it separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
