kfaraz commented on code in PR #13581:
URL: https://github.com/apache/druid/pull/13581#discussion_r1050420691
##########
examples/bin/start-druid-main.py:
##########
@@ -436,43 +428,39 @@ def check_memory_constraint(total_memory, services):
return int(total_memory * 0.8)
-def build_mm_task_java_opts_array(memory_type):
- task_memory = '-D{0}=['.format(TASK_JAVA_OPTS_PROPERTY)
-
- mem_array = TASK_MEM_MAP.get(memory_type)
+def build_mm_task_java_opts_array(task_memory):
+ tasks_memory = '-D{0}=['.format(TASK_JAVA_OPTS_PROPERTY)
+ mem_array = ["-Xms{0}m".format(task_memory),
"-Xmx{0}m".format(task_memory),
"-XX:MaxDirectMemorySize={0}m".format(task_memory)]
Review Comment:
Thanks, it is much simpler now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
