maytasm opened a new pull request, #13624: URL: https://github.com/apache/druid/pull/13624
Add context to HadoopIngestionSpec ### Description It is possible to pass `context` to ingestion task using task context (https://druid.apache.org/docs/latest/ingestion/tasks.html#context). However, this context is not added to `HadoopIngestionSpec` and is not accessible further downstream in the various `Jobby`. Hadoop ingestion job can also be submitted via command line (non-task)(https://druid.apache.org/docs/latest/ingestion/hadoop.html#command-line-non-task-version). This method only takes the `HadoopIngestionSpec` (not the `HadoopIndexTask`). This does not let the user pass context into Hadoop ingestion job. The fix in this PR is to add `context` map to HadoopIngestionSpec. The `context` map can be set directly in HadoopIngestionSpec if the user is using command line (non-task) version or set in HadoopIndexTask's `context` map which is then automatically added to HadoopIngestionSpec. Note that if context map is set in both HadoopIngestionSpec and HadoopIndexTask, then the context map in HadoopIndexTask will overwrite the one in HadoopIngestionSpec. This PR has: - [x] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
