churromorales opened a new pull request, #13655:
URL: https://github.com/apache/druid/pull/13655
When testing mm-less druid with istio-proxy, I noticed that when you have a
controller that automatically injects the sidecar for all pods in a namespace.
The istio-proxy sidecar gets injected as the first container. The problem here
was the assumption that the first container was always the `druid` container.
Additionally, when something injects sidecars, you don't want to include those
sidecars from the overlord and have that controller inject the sidecar as well.
That would lead to the sidecar being added twice.
I added 2 configuration options which should assist with this.
if you are running with `druid.indexer.runner.sidecarSupport=true`
you can specify
`druid.indexer.runner.primaryContainerName=<overlord_container_name>` to be the
container name for your overlord.
Additionally if you have a controller that adds sidecars dynamically, you
can exclude the sidecar containers from your peon pod. So that way you let the
controller add those sidecars, you are not inheriting them from the overlord
*AND* having the controller add them.
For example if we have this for your overlord podSpec:
```
spec:
containers:
- image: istio:latest
name: istio-proxy
- image: druid:latest
name: druid-overlord
- image: splunk:latest
name: splunk
```
If your istio is automatically injected by a controller then you would
specify this in your overlord config:
```
druid.indexer.runner.primaryContainerName=druid-overlord
druid.indexer.runner.containersToExclude=['istio-proxy']
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
