paul-rogers commented on code in PR #13660:
URL: https://github.com/apache/druid/pull/13660#discussion_r1068759891
##########
integration-tests-ex/docs/guide.md:
##########
@@ -239,3 +239,29 @@ test. Your test will run in parallel with all other IT
categories, which is why
we offered the advice above: the test has to have a good reason to fire up yet
another build task.
+### Choosing the Middle Manager or Indexer
+
+Tests should run on the Middle Manager by default. Tests can optionally runn
on the
Review Comment:
Thanks! Doc typos are not nits...
##########
integration-tests-ex/docs/guide.md:
##########
@@ -239,3 +239,29 @@ test. Your test will run in parallel with all other IT
categories, which is why
we offered the advice above: the test has to have a good reason to fire up yet
another build task.
+### Choosing the Middle Manager or Indexer
+
+Tests should run on the Middle Manager by default. Tests can optionally runn
on the
+Indexer. To run on Indexer:
+
+* In the environment, `export DRUID_INTEGRATION_TEST_INDEXER=indexer`. (Use
`middleManager`
+ otherwise. If the variable is not set, `middleManager` is the default.)
+* The `cluster/<category>/docker-compose.yaml` file should be for the Middle
manager. Create
+ a separate file called `cluster/<category>/docker-compose-indexer.yaml` to
define the
+ Indexer-based cluster.
+* The test `src/test/resources/cluster/<category>/docker.yaml` file should
contain a conditional
Review Comment:
The current structure is as follows:
* The `integration-tests-ex/cases` module contains all the IT tests.
* Tests are grouped into a "category". The category defines the set of JUnit
test to run _and_ the cluster to use to run the tests.
* A test category can "reuse" a cluster definition from some other category,
if no changes are needed.
* With this PR, each test category can have an Indexer and Middle Manager
configuration (as distinct files.)
If I understand correctly, you have an MSQ test that can't run on Indexer,
only MM. In this case, the fourth bullet (run on both) isn't needed.
The default solution is that you'd define your `docker-compose.yaml` file to
include MM. You _would not_ provide a `docker-compose-indexer.yaml` file. When
the `it.sh` script tries to run your test, with
`DRUID_INTEGRATION_TEST_INDEXER=indexer`, the test will fail because of the
missing `docker-compose-indexer.yaml` file.
This should be OK. In Travis, we have a separate entry for each IT: indexer
or not. We'd not include a line for your MSQ test with "indexer".
If we simply want to succeed, but do nothing, then add the following lines
to `cluster.sh` at line 156:
```bash
if [ ! -f "$CLUSTER_DIR/$compose_file" ]; then
if [ $CATEGORY == "SomeMSQTest" ]; then
exit 0 # Silently succeed for SomeMSQTest with
indexer
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
