suneet-s opened a new pull request, #13699:
URL: https://github.com/apache/druid/pull/13699

   ### Description
   
   Add a new API to return the history of changes to automatic compaction 
config history to make it easy for users to see what changes have been made to 
their auto-compaction config.
   
   The API is scoped per dataSource to allow users to triage issues with an 
individual dataSource. The API responds with a list of configs when there is a 
change to either the settings that impact all auto-compaction configs on a 
cluster or the dataSource in question.
   
   I had considered adding another API to expose the entire compaction config 
history as it was stored in the audit table, however I chose against doing 
this, as I didn't think users would want the ability to see this global view.
   
   #### Release note
   New: You can now get the history of changes to automatic compaction config 
for a dataSource via an API.
   
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `DataSourceCompactionConfigHistory#add` - Ensures that only changes that 
affect a particular dataSource's auto-compaction config are added to the history
    * `CoordinatorCompactionConfigsResource#getCompactionConfigHistory` - the 
API endpoint
   
   <hr>
   
   This PR has:
   
   - [ ] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] a release note entry in the PR description.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to