imply-cheddar commented on code in PR #13694:
URL: https://github.com/apache/druid/pull/13694#discussion_r1084719363
##########
processing/src/main/java/org/apache/druid/query/rowsandcols/column/DoubleArrayColumn.java:
##########
@@ -126,4 +74,122 @@ public <T> T as(Class<? extends T> clazz)
}
return null;
}
+
+ private class MyColumnAccessor implements BinarySearchableAccessor
Review Comment:
Generically speaking, yes it would be best to validate that first before
returning the thing.
As a confounding factor, even if the whole column isn't sorted, it could be
sorted in the context of another column. I.e. if a set of rows are sorted by
`(col1, col2)`, then `col2` is not actually sorted if you look at the data, but
when you access it in conjunction with `col1`, it is. I agree that we should
do more to figure this sort of thing out and fail if it's violated, but, for
now, the code is counting on the query planning to do things correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
