tejaswini-imply commented on code in PR #13681: URL: https://github.com/apache/druid/pull/13681#discussion_r1089168202
########## .github/workflows/reusable-revised-its.yml: ########## @@ -0,0 +1,107 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Revised Integration Tests shared workflow +on: + workflow_call: + inputs: + script: + description: 'Which IT script to run' + required: true + type: string + build_jdk: + description: 'Which jdk version was used to build' + required: true + type: string + runtime_jdk: + description: 'Which JDK version to use at runtime' + required: true + type: string + use_indexer: + description: 'Which indexer to use' + required: true + type: string + druid_it_image_name: + required: true + type: string + +env: + MVN: mvn -B + MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true + MAVEN_SKIP_TESTS: -P skip-tests + MAVEN_OPTS: -Xmx3000m Review Comment: Updated the PR, thanks. ########## .github/workflows/it.yml: ########## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +on: + workflow_call + +jobs: + integration-index-tests-middleManager: + strategy: + fail-fast: false + max-parallel: 3 + matrix: + jdk: [8, 11] + testing_group: [batch-index, input-format, input-source, perfect-rollup-parallel-batch-index, kafka-index, kafka-index-slow, kafka-transactional-index, kafka-transactional-index-slow, kafka-data-format, ldap-security, realtime-index, append-ingestion, compaction] + name: (Compile=jdk${{ matrix.jdk }}, Run=jdk${{ matrix.jdk }}, Indexer=middleManager) ${{ matrix.testing_group }} integration test + uses: tejaswini-imply/druid/.github/workflows/reusable-standard-its.yml@update_uts_gha + with: + build_jdk: 8 + runtime_jdk: ${{ matrix.jdk }} + testing_groups: -Dgroups=${{ matrix.testing_group }} + use_indexer: middleManager + + integration-index-tests-indexer: + strategy: + fail-fast: false + max-parallel: 3 + matrix: + jdk: [8, 11] + testing_group: [input-source, perfect-rollup-parallel-batch-index, kafka-index, kafka-transactional-index, kafka-index-slow, kafka-transactional-index-slow, kafka-data-format, append-ingestion, compaction] + name: (Compile=jdk${{ matrix.jdk }}, Run=jdk${{ matrix.jdk }}, Indexer=indexer) ${{ matrix.testing_group }} integration test + uses: tejaswini-imply/druid/.github/workflows/reusable-standard-its.yml@update_uts_gha + with: + build_jdk: 8 + runtime_jdk: ${{ matrix.jdk }} + testing_groups: -Dgroups=${{ matrix.testing_group }} + use_indexer: indexer + + integration-query-tests-middleManager: + strategy: + fail-fast: false + max-parallel: 3 + matrix: + jdk: [8, 11] + testing_group: [query, query-retry, query-error, security, high-availability] + name: (Compile=jdk${{ matrix.jdk }}, Run=jdk${{ matrix.jdk }}, Indexer=middleManager) ${{ matrix.testing_group }} integration test + uses: tejaswini-imply/druid/.github/workflows/reusable-standard-its.yml@update_uts_gha + with: + build_jdk: 8 + runtime_jdk: ${{ matrix.jdk }} + testing_groups: -Dgroups=${{ matrix.testing_group }} + use_indexer: middleManager + override_config_path: ./environment-configs/test-groups/prepopulated-data + + integration-query-tests-middleManager-mariaDB: + strategy: + fail-fast: false + matrix: + jdk: [8, 11] + name: (Compile=jdk8, Run=jdk${{ matrix.jdk }}, Indexer=middleManager) query integration test (mariaDB) + uses: tejaswini-imply/druid/.github/workflows/reusable-standard-its.yml@update_uts_gha + with: + build_jdk: 8 + runtime_jdk: ${{ matrix.jdk }} + testing_groups: -Dgroups=query + use_indexer: middleManager + mysql_driver: org.mariadb.jdbc.Driver + override_config_path: ./environment-configs/test-groups/prepopulated-data + + integration-shuffle-deep-store-tests: + strategy: + fail-fast: false + matrix: + indexer: [indexer, middleManager] + name: (Compile=openjdk8, Run=openjdk8, Indexer=${{ matrix.indexer }}) perfect rollup parallel batch index integration test with deep storage as intermediate store + uses: tejaswini-imply/druid/.github/workflows/reusable-standard-its.yml@update_uts_gha + with: + build_jdk: 8 + runtime_jdk: 8 + testing_groups: -Dgroups=shuffle-deep-store + use_indexer: ${{ matrix.indexer }} + override_config_path: ./environment-configs/test-groups/shuffle-deep-store + + integration-custom-coordinator-duties-tests: + name: (Compile=jdk8, Run=jdk8, Indexer=middleManager) custom coordinator duties integration test + uses: tejaswini-imply/druid/.github/workflows/reusable-standard-its.yml@update_uts_gha + with: + build_jdk: 8 + runtime_jdk: 8 + testing_groups: -Dgroups=custom-coordinator-duties + use_indexer: middleManager + override_config_path: ./environment-configs/test-groups/custom-coordinator-duties + + integration-other-tests: + strategy: + fail-fast: false + matrix: + jdk: [8, 11] + indexer: [middleManager, indexer] + name: (Compile=jdk${{ matrix.jdk }}, Run=jdk${{ matrix.jdk }}, Indexer=${{ matrix.indexer }}) other integration tests + uses: tejaswini-imply/druid/.github/workflows/reusable-standard-its.yml@update_uts_gha + with: + build_jdk: 8 + runtime_jdk: ${{ matrix.jdk }} + testing_groups: -DexcludedGroups=batch-index,input-format,input-source,perfect-rollup-parallel-batch-index,kafka-index,query,query-retry,query-error,realtime-index,security,ldap-security,s3-deep-storage,gcs-deep-storage,azure-deep-storage,hdfs-deep-storage,s3-ingestion,kinesis-index,kinesis-data-format,kafka-transactional-index,kafka-index-slow,kafka-transactional-index-slow,kafka-data-format,hadoop-s3-to-s3-deep-storage,hadoop-s3-to-hdfs-deep-storage,hadoop-azure-to-azure-deep-storage,hadoop-azure-to-hdfs-deep-storage,hadoop-gcs-to-gcs-deep-storage,hadoop-gcs-to-hdfs-deep-storage,aliyun-oss-deep-storage,append-ingestion,compaction,high-availability,upgrade,shuffle-deep-store,custom-coordinator-duties + use_indexer: ${{ matrix.indexer }} + + integration-batch_index_k8s: + name: (Compile=jdk8, Run=jdk8, Cluster Build On K8s) ITNestedQueryPushDownTest integration test + runs-on: ubuntu-22.04 + env: + MVN: mvn --no-snapshot-updates + MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true + CONFIG_FILE: k8s_run_config_file.json + IT_TEST: -Dit.test=ITNestedQueryPushDownTest + POD_NAME: int-test + POD_NAMESPACE: default + BUILD_DRUID_CLUSTER: true + steps: + - name: Checkout branch + uses: actions/checkout@v3 + - name: Setup java + uses: actions/setup-java@v3 + with: + distribution: 'zulu' + java-version: 8 + - name: Restore Maven repository + uses: actions/cache@v3 + with: + path: ~/.m2/repository + key: maven-${{ runner.os }}-8-${{ hashFiles('**/pom.xml') }} + - name: Run IT + run: | + ${MVN} verify -pl integration-tests -P int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME} -Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLUSTER} Review Comment: Updated the PR, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
