paul-rogers commented on code in PR #13131: URL: https://github.com/apache/druid/pull/13131#discussion_r1091305140
########## docs/operations/clean-metadata-store.md: ########## @@ -143,7 +143,7 @@ Datasource cleanup uses the following configuration: ### Indexer task logs -You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage. +You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage. The cleanup includes the `druid_tasks` and `druid_tasklogs` tables in the metadata database, and the task logs in deep storage. (Note that `druid_tasklogs` is no longer used and will already be empty, unless the druid version is older.) Review Comment: Looks good. The following is a bit unclear: > (Note that `druid_tasklogs` is no longer used and will already be empty, unless the druid version is older.) Maybe: > The cleanup includes the `druid_tasks` table in the metadata database, and the task logs in deep storage. In previous versions of Druid task logs were stored in the the metadata database table `druid_tasklogs`. However, this table is no longer used in the current version and the table is always empty. Also, I like your "periodically" wording so we know that that this isn't one shot: > You can configure the Overlord to delete indexer logs periodically. Indexer logs include ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
