abhishekagarwal87 commented on code in PR #13725:
URL: https://github.com/apache/druid/pull/13725#discussion_r1091910208
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocationQueue.java:
##########
@@ -301,7 +299,7 @@ private void processBatchesDue()
nextScheduleDelay = Math.max(0, maxWaitTimeMillis - timeElapsed);
}
scheduleQueuePoll(nextScheduleDelay);
- log.info("Processed [%d] batches, next execution in [%d ms]",
numProcessedBatches, nextScheduleDelay);
+ log.debug("Processed [%d] batches, next execution in [%d ms]",
numProcessedBatches, nextScheduleDelay);
Review Comment:
this is the noisy line, right?
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocationQueue.java:
##########
@@ -601,7 +599,7 @@ synchronized void handleResult(SegmentAllocateResult
result, SegmentAllocateRequ
emitTaskMetric("task/action/success/count", 1L, request);
requestToFuture.remove(request).complete(result.getSegmentId());
} else if (request.canRetry()) {
- log.info(
+ log.debug(
Review Comment:
this should still be info.
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocationQueue.java:
##########
@@ -355,7 +353,7 @@ private boolean processBatch(AllocateRequestBatch
requestBatch)
emitBatchMetric("task/action/batch/attempts", 1L, requestKey);
emitBatchMetric("task/action/batch/runTime", (System.currentTimeMillis() -
startTimeMillis), requestKey);
- log.info("Successfully processed [%d / %d] requests in batch [%s].",
successCount, batchSize, requestKey);
+ log.debug("Successfully processed [%d / %d] requests in batch [%s].",
successCount, batchSize, requestKey);
Review Comment:
is it too noisy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
