cryptoe commented on code in PR #13670: URL: https://github.com/apache/druid/pull/13670#discussion_r1092168841
########## indexing-service/src/main/java/org/apache/druid/indexing/common/TaskMetadata.java: ########## @@ -0,0 +1,38 @@ +package org.apache.druid.indexing.common; Review Comment: This class seems avoidable. Looks like this is introduced cause of parseExceptionHandler cause you need the taskId, groupId, data source. TaskID, groupId is part of the Task.java and seems to be repeated here. What happens if task is operating on 2 data sources ? So for the above reasons I think we should think of another way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
