jwitko opened a new pull request, #13746: URL: https://github.com/apache/druid/pull/13746
Fixes #13745 ### Description If a user deploying via the Apache Druid helm chart is while using `druid-kubernetes-extensions` then there is no need to set a zookeeper host however the helm chart will fail if the user does not. This change will remove the requirement for setting a zookeeper host and adds a comment to the values file to help helm chart consumers understand. ### Alternatives An alternative design could have been to look for the druid config settings required [in the documentation](https://druid.apache.org/docs/latest/development/extensions-core/kubernetes.html) and base the conditional off of those but since they can be set at a per-process or global config level I thought it better to keep it simple. #### Release note Fixed: Helm chart no longer requires a ZooKeeper host be set for users using `druid-kubernetes-extensions` This PR has: - [X] been self-reviewed. - [X] added documentation for new or modified features or behaviors. - [X] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [X] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
