imply-cheddar commented on code in PR #13739: URL: https://github.com/apache/druid/pull/13739#discussion_r1095428678
########## processing/src/test/java/org/apache/druid/segment/vector/TestVectorColumnSelectorFactory.java: ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment.vector; + +import org.apache.druid.java.util.common.UOE; +import org.apache.druid.query.dimension.DimensionSpec; +import org.apache.druid.segment.column.ColumnCapabilities; + +import javax.annotation.Nullable; +import java.util.LinkedHashMap; +import java.util.Map; + +public class TestVectorColumnSelectorFactory implements VectorColumnSelectorFactory +{ + private ReadableVectorInspector inspector = null; + + private final Map<String, SingleValueDimensionVectorSelector> singleValDimSelectors = new LinkedHashMap<>(); + private final Map<String, MultiValueDimensionVectorSelector> multiValDimSelectors = new LinkedHashMap<>(); + private final Map<String, VectorValueSelector> vectorValueSelectors = new LinkedHashMap<>(); + private final Map<String, VectorObjectSelector> vectorObjectSelectors = new LinkedHashMap<>(); + private final Map<String, ColumnCapabilities> capabilitiesMap = new LinkedHashMap<>(); + + public TestVectorColumnSelectorFactory addSVDVS(String col, SingleValueDimensionVectorSelector selector) Review Comment: Yeah... probably. I didn't know exactly how I was going to use the thing as I threw these methods on it, but looking back at how it is used, that would've worked for the usage. 🤷 It's a test class whose API can be plenty fluid, we can make it better when next we come to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
