hqx871 commented on code in PR #13303:
URL: https://github.com/apache/druid/pull/13303#discussion_r1096461066
##########
core/src/main/java/org/apache/druid/indexer/partitions/DimensionRangePartitionsSpec.java:
##########
@@ -144,6 +146,17 @@ public List<String> getPartitionDimensions()
return partitionDimensions;
}
+ public DimensionRangeShardSpec createShardSpec(
Review Comment:
> Secretly choosing a partition dimension behind the scenes is probably not
so great
This is just to be compatible with what single_dim like before my pr. I do
not make any modification here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
