LakshSingla commented on code in PR #13706:
URL: https://github.com/apache/druid/pull/13706#discussion_r1097200159
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/TombstoneHelper.java:
##########
@@ -147,22 +248,30 @@ private DataSegment
createTombstoneForTimeChunkInterval(String dataSource, Strin
}
-
/**
* Helper method to prune required tombstones. Only tombstones that cover
used intervals will be created
* since those that not cover used intervals will be redundant.
+ *
+ * @param inputIntervals Intervals corresponding to the task
+ * @param dataSource Datasource corresponding to the task
+ * @param taskActionClient Task action client to fetch the used intervals
for the datasource
* @return Intervals corresponding to used segments that overlap with any of
the spec's input intervals
* @throws IOException If used segments cannot be retrieved
*/
- public List<Interval> getCondensedUsedIntervals() throws IOException
+ public static List<Interval> getCondensedUsedIntervals(
Review Comment:
Since this didn't rely on anything state input, I made it static. Making it
private and removing static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
