imply-cheddar commented on code in PR #13732:
URL: https://github.com/apache/druid/pull/13732#discussion_r1098041858
##########
core/src/main/java/org/apache/druid/math/expr/ExprEval.java:
##########
@@ -463,6 +479,13 @@ public static ExprEval bestEffortOf(@Nullable Object val)
return ofArray(coerced.lhs, coerced.rhs);
}
+ // in 'best effort' mode, we couldn't possibly use byte[] as a complex or
anything else useful without type
+ // knowledge, so lets turn it into a base64 encoded string so at least
something downstream can use it by decoding
+ // back into bytes
+ if (val instanceof byte[]) {
+ return new StringExprEval(StringUtils.encodeBase64String((byte[]) val));
+ }
Review Comment:
Do we even need to base64 it? why not just keep it as a `byte[]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
