imply-cheddar commented on code in PR #13779:
URL: https://github.com/apache/druid/pull/13779#discussion_r1100957121
##########
processing/src/main/java/org/apache/druid/segment/virtual/NestedFieldVirtualColumn.java:
##########
@@ -647,7 +650,10 @@ public ColumnCapabilities capabilities(ColumnInspector
inspector, String columnN
final ColumnCapabilities capabilities =
inspector.getColumnCapabilities(this.columnName);
if (capabilities != null) {
- if (!capabilities.isPrimitive() &&
capabilities.isDictionaryEncoded().isTrue()) {
+ // if the underlying column is a nested column (and persisted to disk,
re: the dictionary encoded check)
Review Comment:
Do we really have no better way of determining if we have been persisted
than checking `isDictionaryEncoded()`? Given that we are already a
`NestedFieldVirtualColumn` and supposedly working with a `NestedField` that we
understand the class of, I wonder if we couldn't have something more specific.
Maybe for another day, but perhaps we could have a
`NestedFieldColumnCapabilities` that we could cast to and get access to more
specific methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
