github-code-scanning[bot] commented on code in PR #13787: URL: https://github.com/apache/druid/pull/13787#discussion_r1103281589
########## examples/quickstart/jupyter-notebooks/druidapi/html_table.py: ########## @@ -0,0 +1,122 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from IPython.display import display, HTML +from .base_table import BaseTable +from html import escape + +STYLES = ''' +<style> + .druid table { + border: 1px solid black; + border-collapse: collapse; + } + + .druid th, .druid td { + padding: 4px 1em ; + text-align: left; + } + + td.druid-right, th.druid-right { + text-align: right; + } + + td.druid-center, th.druid-center { + text-align: center; + } + + .druid .druid-left { + text-align: left; + } + + .druid-alert { + color: red; + } +</style> +''' + +def escape_for_html(s): + # Anoying: IPython treats $ as the start of Latex, which is cool, + # but not wanted here. + return s.replace('$', '\\$') + +def html(s): + s = '<div class="druid">' + escape_for_html(s) + '</div>' + display(HTML(s)) + +def html_error(s): + s = '<div class="druid-alert">' + escape_for_html(s.replace('\n', '<br/>')) + '</div>' + display(HTML(s)) + +def styles(): + display(HTML(STYLES)) + +alignments = ['druid-left', 'druid-center', 'druid-right'] + +def start_tag(tag, align): + s = '<' + tag + if align is not None: + s += ' class="{}"'.format(alignments[align]) + return s + '>' + +class HtmlTable(BaseTable): + + def __init__(self): + BaseTable.__init__(self) + self._headers = None Review Comment: ## Overwriting attribute in super-class or sub-class Assignment overwrites attribute _headers, which was previously defined in superclass [BaseTable](1). [Show more details](https://github.com/apache/druid/security/code-scanning/4261) ########## examples/quickstart/jupyter-notebooks/druidapi/html_table.py: ########## @@ -0,0 +1,122 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from IPython.display import display, HTML +from .base_table import BaseTable +from html import escape + +STYLES = ''' +<style> + .druid table { + border: 1px solid black; + border-collapse: collapse; + } + + .druid th, .druid td { + padding: 4px 1em ; + text-align: left; + } + + td.druid-right, th.druid-right { + text-align: right; + } + + td.druid-center, th.druid-center { + text-align: center; + } + + .druid .druid-left { + text-align: left; + } + + .druid-alert { + color: red; + } +</style> +''' + +def escape_for_html(s): + # Anoying: IPython treats $ as the start of Latex, which is cool, + # but not wanted here. + return s.replace('$', '\\$') + +def html(s): + s = '<div class="druid">' + escape_for_html(s) + '</div>' + display(HTML(s)) + +def html_error(s): + s = '<div class="druid-alert">' + escape_for_html(s.replace('\n', '<br/>')) + '</div>' + display(HTML(s)) + +def styles(): + display(HTML(STYLES)) + +alignments = ['druid-left', 'druid-center', 'druid-right'] + +def start_tag(tag, align): + s = '<' + tag + if align is not None: + s += ' class="{}"'.format(alignments[align]) + return s + '>' + +class HtmlTable(BaseTable): + + def __init__(self): + BaseTable.__init__(self) + self._headers = None + self._align = None + self._col_fmt = None Review Comment: ## Overwriting attribute in super-class or sub-class Assignment overwrites attribute _col_fmt, which was previously defined in superclass [BaseTable](1). [Show more details](https://github.com/apache/druid/security/code-scanning/4263) ########## examples/quickstart/jupyter-notebooks/druidapi/html_table.py: ########## @@ -0,0 +1,122 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from IPython.display import display, HTML +from .base_table import BaseTable +from html import escape + +STYLES = ''' +<style> + .druid table { + border: 1px solid black; + border-collapse: collapse; + } + + .druid th, .druid td { + padding: 4px 1em ; + text-align: left; + } + + td.druid-right, th.druid-right { + text-align: right; + } + + td.druid-center, th.druid-center { + text-align: center; + } + + .druid .druid-left { + text-align: left; + } + + .druid-alert { + color: red; + } +</style> +''' + +def escape_for_html(s): + # Anoying: IPython treats $ as the start of Latex, which is cool, + # but not wanted here. + return s.replace('$', '\\$') + +def html(s): + s = '<div class="druid">' + escape_for_html(s) + '</div>' + display(HTML(s)) + +def html_error(s): + s = '<div class="druid-alert">' + escape_for_html(s.replace('\n', '<br/>')) + '</div>' + display(HTML(s)) + +def styles(): + display(HTML(STYLES)) + +alignments = ['druid-left', 'druid-center', 'druid-right'] + +def start_tag(tag, align): + s = '<' + tag + if align is not None: + s += ' class="{}"'.format(alignments[align]) + return s + '>' + +class HtmlTable(BaseTable): + + def __init__(self): + BaseTable.__init__(self) + self._headers = None + self._align = None Review Comment: ## Overwriting attribute in super-class or sub-class Assignment overwrites attribute _align, which was previously defined in superclass [BaseTable](1). [Show more details](https://github.com/apache/druid/security/code-scanning/4262) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
