clintropolis commented on code in PR #13777: URL: https://github.com/apache/druid/pull/13777#discussion_r1103891904
########## sql/src/main/java/org/apache/druid/sql/calcite/schema/InformationSchema.java: ########## @@ -73,44 +73,65 @@ public class InformationSchema extends AbstractSchema private static final String SCHEMATA_TABLE = "SCHEMATA"; private static final String TABLES_TABLE = "TABLES"; private static final String COLUMNS_TABLE = "COLUMNS"; - private static final RowSignature SCHEMATA_SIGNATURE = RowSignature Review Comment: oh i see in the description something about nullable bigint, but I think the problem is probably using `RowSignatures.toRelDataType` which only allows numeric columns to be nullable if `druid.generic.useDefaultValueForNull=false`, which is valid for native druid engine, but probably isn't the correct behavior for these tables. I wonder if it would it be the correct behavior if these were executed by the Druid engine though and `druid.generic.useDefaultValueForNull=true`? I hope to switch the default to be `false` someday to be more sql compliant out of the box, but perhaps worth thinking about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
