abhishekagarwal87 commented on code in PR #13795:
URL: https://github.com/apache/druid/pull/13795#discussion_r1106959050
##########
distribution/docker/druid.sh:
##########
@@ -196,4 +198,14 @@ then
mkdir -p ${DRUID_DIRS_TO_CREATE}
fi
+# Check if the other configuration directorie variable is set and if it is,
copy the files from there
+if [ -n "$DRUID_ADDITIONAL_CONF_DIR" ]
+then
+ if [ -d "$DRUID_ADDITIONAL_CONF_DIR" ]
+ then
+ cp $DRUID_ADDITIONAL_CONF_DIR/* $COMMON_CONF_DIR
+ fi
+fi
+
+
exec bin/run-java ${JAVA_OPTS} -cp $COMMON_CONF_DIR:$SERVICE_CONF_DIR:lib/*:
org.apache.druid.cli.Main server $@
Review Comment:
why not take an env such as "EXTRA_CLASSPATH" and then add it here in the
command line? No need to copy files and users can pass multiple directories if
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
