paul-rogers commented on code in PR #13782:
URL: https://github.com/apache/druid/pull/13782#discussion_r1107401314
##########
.github/workflows/standard-its.yml:
##########
@@ -100,6 +100,54 @@ jobs:
override_config_path:
./environment-configs/test-groups/custom-coordinator-duties
group: custom coordinator duties
+ integration-k8s-leadership-tests:
+ name: (Compile=openjdk8, Run=openjdk8, Cluster Build On K8s)
ITNestedQueryPushDownTest integration test
+ runs-on: ubuntu-22.04
+ env:
+ MVN: mvn --no-snapshot-updates
+ MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true
-Dmaven.javadoc.skip=true
+ CONFIG_FILE: k8s_run_config_file.json
+ IT_TEST: -Dit.test=ITNestedQueryPushDownTest
+ POD_NAME: int-test
+ POD_NAMESPACE: default
+ BUILD_DRUID_CLUSTER: true
+ steps:
+ - name: Checkout branch
+ uses: actions/checkout@v3
+
+ - name: Setup java
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: 8
+
+ - name: Restore Maven repository
+ id: maven-restore
+ uses: actions/cache/restore@v3
+ with:
+ path: ~/.m2/repository
+ key: maven-${{ runner.os }}-8-${{ github.sha }}
+
+ - name: Maven build
+ if: steps.maven-restore.outputs.cache-hit != 'true'
+ run: |
+ ./it.sh ci
+
+ - name: Run IT
+ id: test
+ run: |
+ # Debug echo
+ echo "MAVEN_OPTS='-Xmx2048m' ${MVN} verify -pl integration-tests -P
int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME}
-Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLUSTER}"
+ MAVEN_OPTS='-Xmx2048m' ${MVN} verify -pl integration-tests -P
int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME}
-Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLUSTER}
+
+ - name: Debug on failure
+ if: ${{ failure() && steps.test.conclusion == 'failure' }}
+ run: |
+ for v in broker middlemanager router coordinator historical ; do
+ echo
"------------------------druid-tiny-cluster-"$v"s-0-------------------------";
+ sudo /usr/local/bin/kubectl logs --tail 1000
druid-tiny-cluster-"$v"s-0;
Review Comment:
The above will emit up to 5000 log lines. Is this what we want? Is there a
better way to preserve logs?
##########
.github/workflows/standard-its.yml:
##########
@@ -100,6 +100,54 @@ jobs:
override_config_path:
./environment-configs/test-groups/custom-coordinator-duties
group: custom coordinator duties
+ integration-k8s-leadership-tests:
+ name: (Compile=openjdk8, Run=openjdk8, Cluster Build On K8s)
ITNestedQueryPushDownTest integration test
+ runs-on: ubuntu-22.04
+ env:
+ MVN: mvn --no-snapshot-updates
+ MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true
-Dmaven.javadoc.skip=true
+ CONFIG_FILE: k8s_run_config_file.json
+ IT_TEST: -Dit.test=ITNestedQueryPushDownTest
+ POD_NAME: int-test
+ POD_NAMESPACE: default
+ BUILD_DRUID_CLUSTER: true
+ steps:
+ - name: Checkout branch
+ uses: actions/checkout@v3
+
+ - name: Setup java
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: 8
+
+ - name: Restore Maven repository
+ id: maven-restore
+ uses: actions/cache/restore@v3
+ with:
+ path: ~/.m2/repository
+ key: maven-${{ runner.os }}-8-${{ github.sha }}
+
+ - name: Maven build
+ if: steps.maven-restore.outputs.cache-hit != 'true'
+ run: |
+ ./it.sh ci
+
+ - name: Run IT
+ id: test
+ run: |
+ # Debug echo
+ echo "MAVEN_OPTS='-Xmx2048m' ${MVN} verify -pl integration-tests -P
int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME}
-Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLUSTER}"
+ MAVEN_OPTS='-Xmx2048m' ${MVN} verify -pl integration-tests -P
int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME}
-Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLUSTER}
Review Comment:
Nit: you'll get more reliable info if we first set `MAVEN_OPTS`, then do
`echo $MAVEN_OPTS`. The result avoid copy/paste errors in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]