churromorales commented on code in PR #13476: URL: https://github.com/apache/druid/pull/13476#discussion_r1107647645
########## extensions-contrib/kubernetes-overlord-extensions/src/test/java/org/apache/druid/k8s/overlord/KubernetesTaskRunnerTest.java: ########## @@ -92,7 +104,10 @@ private TaskLogPusher taskLogPusher; private DruidNode node; - public KubernetesTaskRunnerTest() + private final boolean useMultipleBaseTaskDirPaths; + + + public KubernetesTaskRunnerTest(boolean useMultipleBaseTaskDirPaths) Review Comment: 1. you have to attach multiple volumes in the overlord. Tasks inherit spec from its parent, which is now the overlord. 2. you would have to pass the multiple directories to the task, which is not happening, so it wont help at all. 3. also there is no competition for the resources in k8s mode as the task is the only one writing to that volume, unlike MM-mode. I don't think this would help in the future either as @imply-cheddar stated, you are still passing a single path to the peon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
