imply-elliott commented on code in PR #13772:
URL: https://github.com/apache/druid/pull/13772#discussion_r1108928170


##########
.github/workflows/reusable-standard-its.yml:
##########
@@ -74,12 +74,15 @@ jobs:
         with:
           path: ~/.m2/repository
           key: maven-${{ runner.os }}-${{ inputs.build_jdk }}-${{ github.sha }}
-          fail-on-cache-miss: true
+
+      - name: Maven build
+        if: steps.maven-restore.outputs.cache-hit != 'true'
+        run: |
+          ./it.sh ci

Review Comment:
   That bug is unfortunate.  
   This workaround will do great to unblock; but I'm going to do some tests 
with artifacts as a replacement for Caches that i was prototyping a bit ago.  
The fact that if we cache miss means all the steps need to build again just 
sucks.  Caches are a problem for us, as Github only allows 10G before pruning, 
and that's basically one SHA's worth, so this may bite us hard when the project 
gets a lot of activity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to