abhishekagarwal87 commented on code in PR #13788: URL: https://github.com/apache/druid/pull/13788#discussion_r1112853903
########## sql/src/main/java/org/apache/druid/sql/calcite/planner/PlannerFactory.java: ########## @@ -52,7 +52,7 @@ import java.util.Map; import java.util.Properties; -public class PlannerFactory +public class PlannerFactory implements PlannerToolbox Review Comment: why does PlannerFactory has to implement PlannerToolbox? Instead, it could take plannerToolbox as an argument. is the implementation any different from SimplePlannerToolbox? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
