gianm commented on code in PR #13506:
URL: https://github.com/apache/druid/pull/13506#discussion_r1114232945
##########
processing/src/main/java/org/apache/druid/frame/field/StringFieldReader.java:
##########
@@ -87,6 +87,14 @@ public DimensionSelector makeDimensionSelector(
return new Selector(memory, fieldPointer, extractionFn, false);
}
+ @Override
+ public boolean isNull(Memory memory, long position)
+ {
+ return memory.getByte(position) == StringFieldWriter.NULL_BYTE
+ && memory.getByte(position + 1) ==
StringFieldWriter.VALUE_TERMINATOR
+ && memory.getByte(position + 2) == StringFieldWriter.ROW_TERMINATOR;
Review Comment:
There isn't necessarily going to be an extra byte of padding, and I'm not
sure that reading a 3-byte array is going to be better. I'd prefer to leave
this as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
