kfaraz commented on code in PR #13845:
URL: https://github.com/apache/druid/pull/13845#discussion_r1118005529
##########
.github/workflows/static-checks.yml:
##########
@@ -56,7 +56,7 @@ jobs:
- name: packaging check
run: |
./.github/scripts/setup_generate_license.sh
- ${MVN} clean install -Prat -Pbundle-contrib-exts --fail-at-end \
Review Comment:
Keeping this profile in the command leads to misleading warning messages
such as this one:
https://github.com/apache/druid/actions/runs/4261844965/jobs/7416643271#step:5:22535
```
Warning: The requested profile "bundle-contrib-exts" could not be activated
because it does not exist.
```
This is because the profile `bundle-contrib-exts` is present only in the
distribution module and that module has been excluded in the first command here.
https://github.com/apache/druid/blob/6bb5effa7bb1c7a31cff270818d035bdfb7a7883/.github/workflows/static-checks.yml#L56-L62
I have retained the `-Pbundle-contrib-exts` for the second command, where
the distribution module has been targeted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
