paul-rogers commented on PR #13787: URL: https://github.com/apache/druid/pull/13787#issuecomment-1445533336
Did some last-minute cleanup before this library goes public: * Refactored the "display" items in the API into a separate display client. This makes clear which methods are for use in a notebook (because they display an HTML table) and which are just plain old Python methods. * Refactored HTML support to be cleaner and better separated from the rest of the code. * Used the Python `@property` annotation to simplify zero-argument getters: `druid.sql` rather than `druid.sql()`, say. * Created a test suite which is not yet part of this PR. Running that suite found several bugs and several areas that could e simpler. * Updated notebooks to reflect the code changes. * Reran the `druidapi` based notebooks to verify things work. * Added a `README.md` file for the library. It is a bit minimal at present, but is at least a start. The result is that the functionality is the same, but a few operations moved around. For example, to display the results of a SQL statement was `sql_client.show(sql)`. It is now `display_client.sql(sql)`. And so on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
