gianm commented on code in PR #13880:
URL: https://github.com/apache/druid/pull/13880#discussion_r1127065591
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java:
##########
@@ -166,7 +167,7 @@ public ListenableFuture<TaskStatus> run(Task task)
PeonCommandContext context = new PeonCommandContext(
generateCommand(task),
javaOpts(task),
- dirTracker.getTaskDir(task.getId()),
+ new File(taskConfig.getBaseTaskDirPath()),
Review Comment:
`getBaseTaskDirPath` is for JSON backwards compat; it may be null and isn't
used elsewhere. Better to do `getBaseTaskDirPaths().get(0)`. Please also add
`@Deprecated` to `TaskConfig.getBaseTaskDirPath` to make it clearer to others
that this method shouldn't be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
