clintropolis commented on code in PR #13889:
URL: https://github.com/apache/druid/pull/13889#discussion_r1127288591
##########
processing/src/main/java/org/apache/druid/segment/nested/GlobalDictionaryEncodedFieldColumnWriter.java:
##########
@@ -224,6 +224,7 @@ public void writeTo(int finalRowCount, FileSmoosher
smoosher) throws IOException
bitmapIndexWriter.write(
indexSpec.getBitmapSerdeFactory().getBitmapFactory().makeImmutableBitmap(bitmap)
);
+ bitmap.clear(); // Reclaim memory
Review Comment:
i suppose alternatively we could change to classic for loop and just set
bitmaps[i] to be null to let the gc reclaim it all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
