nlippis commented on code in PR #13896:
URL: https://github.com/apache/druid/pull/13896#discussion_r1130054888
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java:
##########
@@ -313,61 +288,6 @@ public Map<String, Long> getTotalTaskSlotCount()
return ImmutableMap.of("taskQueue", (long) taskQueueConfig.getMaxSize());
}
- private List<String> javaOpts(Task task)
- {
- final List<String> javaOpts = new ArrayList<>();
- Iterables.addAll(javaOpts, k8sConfig.javaOptsArray);
-
- // Override task specific javaOpts
- Object taskJavaOpts = task.getContextValue(
- ForkingTaskRunnerConfig.JAVA_OPTS_PROPERTY
- );
- if (taskJavaOpts != null) {
- Iterables.addAll(
- javaOpts,
- new QuotableWhiteSpaceSplitter((String) taskJavaOpts)
- );
- }
-
- javaOpts.add(StringUtils.format("-Ddruid.port=%d",
DruidK8sConstants.PORT));
- javaOpts.add(StringUtils.format("-Ddruid.plaintextPort=%d",
DruidK8sConstants.PORT));
- javaOpts.add(StringUtils.format("-Ddruid.tlsPort=%d",
node.isEnableTlsPort() ? DruidK8sConstants.TLS_PORT : -1));
- javaOpts.add(StringUtils.format(
- "-Ddruid.task.executor.tlsPort=%d",
- node.isEnableTlsPort() ? DruidK8sConstants.TLS_PORT : -1
- ));
- javaOpts.add(StringUtils.format("-Ddruid.task.executor.enableTlsPort=%s",
node.isEnableTlsPort())
- );
- return javaOpts;
- }
-
- private List<String> generateCommand(Task task)
- {
- final List<String> command = new ArrayList<>();
- command.add("/peon.sh");
- command.add(taskConfig.getBaseTaskDirPaths().get(0));
- command.add(task.getId());
- command.add("1"); // the attemptId is always 1, we never run the task
twice on the same pod.
-
- String nodeType = task.getNodeType();
- if (nodeType != null) {
- command.add("--nodeType");
- command.add(nodeType);
- }
-
- // If the task type is queryable, we need to load broadcast segments on
the peon, used for
- // join queries
- if (task.supportsQueries()) {
- command.add("--loadBroadcastSegments");
- command.add("true");
- }
- log.info(
- "Peon Command for K8s job: %s",
-
ForkingTaskRunner.getMaskedCommand(startupLoggingConfig.getMaskProperties(),
command)
- );
- return command;
- }
-
Review Comment:
No changes are required to CliPeon or AbstractTask. With the
`PodTemplateTaskAdapter` everything is up to the user to specify. Our plan
moving forward will be for sane defaults to be set within helm but those
changes will be made in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
