suneet-s commented on code in PR #13906:
URL: https://github.com/apache/druid/pull/13906#discussion_r1131404039
##########
sql/src/main/java/org/apache/druid/sql/SqlExecutionReporter.java:
##########
@@ -94,6 +94,9 @@ public void emit()
metricBuilder.setDimension("id", plannerContext.getSqlQueryId());
metricBuilder.setDimension("nativeQueryIds",
plannerContext.getNativeQueryIds().toString());
}
+ if (stmt.sqlToolbox.engine != null) {
+ metricBuilder.setDimension("engine", stmt.sqlToolbox.engine.name());
Review Comment:
I chose this instead of `plannerContext` because it looks like `sqlToolbox`
is never null, while `plannerContext` might be null. Also, having to a nested
if to check that the engine in the plannerContext is not null, seemed like it
would make the code harder to read / follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
