cryptoe opened a new pull request, #13928:
URL: https://github.com/apache/druid/pull/13928
It's not optimum to have so many tuning parameters in the docs. Features
like`intermediateSuperSorterStorageMaxLocalBytes`,`maxInputBytesPerWorker`,`composedIntermediateSuperSorterStorageEnabled`,
`clusterStatisticsMergeMode` are more developer focused and should not be set
by external users until they face corner cases.
I think we should remove them until we have a good enough `auto` mode to
free up our docs.
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are
corner cases and error conditions handled, such as when there are insufficient
resources?
- Class organization and design (how the logic is split between classes,
inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods,
parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of
emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative
name) for every design (or naming) decision point and compare the alternatives
with the designs that you've implemented (or the names you've chosen) to
highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in
this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in
the development mailing list), link to that discussion from this PR description
and explain what have changed in your final design compared to your original
proposal or the consensus version in the end of the discussion. If something
hasn't changed since the original discussion, you can omit a detailed
discussion of those aspects of the design here, perhaps apart from brief
mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small
changes. -->
#### Release note
Removing MSQ context params
`intermediateSuperSorterStorageMaxLocalBytes`,`maxInputBytesPerWorker`,
`composedIntermediateSuperSorterStorageEnabled`, `clusterStatisticsMergeMode`
from docs since they should not be set by external users.
This PR has:
- [x] been self-reviewed.
- [x] a release note entry in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
