gianm commented on code in PR #13887:
URL: https://github.com/apache/druid/pull/13887#discussion_r1134697125
##########
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchMergeAggregator.java:
##########
@@ -58,12 +58,20 @@ public ArrayOfDoublesSketchMergeAggregator(
@Override
public void aggregate()
{
- final ArrayOfDoublesSketch update = selector.getObject();
+ final Object update = selector.getObject();
if (update == null) {
return;
}
+ final ArrayOfDoublesSketch sketch;
+ if (update instanceof ArrayOfDoublesSketch) {
Review Comment:
Ah, in this case we have a special function: `complex_decode_base64('type
name', 'base64 bytes')`. I think the type name for this case is
`arrayOfDoublesSketch`.
##########
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchMergeAggregator.java:
##########
@@ -58,12 +58,20 @@ public ArrayOfDoublesSketchMergeAggregator(
@Override
public void aggregate()
{
- final ArrayOfDoublesSketch update = selector.getObject();
+ final Object update = selector.getObject();
if (update == null) {
return;
}
+ final ArrayOfDoublesSketch sketch;
+ if (update instanceof ArrayOfDoublesSketch) {
Review Comment:
Ah, in this case we have a special SQL function:
`complex_decode_base64('type name', 'base64 bytes')`. I think the type name for
this case is `arrayOfDoublesSketch`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
