clintropolis opened a new pull request, #13930:
URL: https://github.com/apache/druid/pull/13930
### Description
This PR adds some additional null checks to `HttpServerInventoryView`,
`HttpRemoteTaskRunner`, `LookupNodeDiscovery`, and `SystemSchema` to ensure
that the `DruidService` they are trying to extract from `DiscoveryDruidNode`
are not null.
This change was motivated by an encounter with a null pointer exception in
`HttpServerInventoryView` when using 'indexer' nodes to handle ingestion, which
prior to #12640 used to announce themselves as both 'indexer' and 'peon' node
roles, with the latter having an empty services set. When the indexer goes
offline, the empty services section caused a null pointer exception since it
was expected to never be null.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
