somu-imply commented on code in PR #13934:
URL: https://github.com/apache/druid/pull/13934#discussion_r1137777908
##########
processing/src/main/java/org/apache/druid/segment/UnnestStorageAdapter.java:
##########
@@ -291,34 +306,26 @@ void add(@Nullable final Filter filter)
}
}
}
-
- if (requiredColumns.contains(outputColumnName)) {
- // Try to move filter pre-correlate if possible.
- final Filter newFilter =
rewriteFilterOnUnnestColumnIfPossible(filter, inputColumn,
inputColumnCapabilites);
- if (newFilter != null) {
- preFilters.add(newFilter);
- } else {
- postFilters.add(filter);
- }
- } else {
- preFilters.add(filter);
- }
+ preFilters.add(filter);
}
}
final FilterSplitter filterSplitter = new FilterSplitter();
- if (allowSet != null && !allowSet.isEmpty()) {
- // Filter on input column if possible (it may be faster); otherwise use
output column.
- filterSplitter.add(new InDimFilter(inputColumn != null ? inputColumn :
outputColumnName, allowSet));
- }
-
if (queryFilter instanceof AndFilter) {
for (Filter filter : ((AndFilter) queryFilter).getFilters()) {
- filterSplitter.add(filter);
+ filterSplitter.addPreFilter(filter);
+ }
+ } else {
+ filterSplitter.addPreFilter(queryFilter);
+ }
+
+ if (unnestFilter instanceof AndFilter) {
+ for (Filter filter : ((AndFilter) unnestFilter).getFilters()) {
+ filterSplitter.addPostFilterWithPreFilterIfRewritePossible(filter);
}
} else {
- filterSplitter.add(queryFilter);
+ filterSplitter.addPostFilterWithPreFilterIfRewritePossible(unnestFilter);
}
Review Comment:
We break it up in the case of AND so that we can find out if one of them can
be added to the pre filters through re-write. Adding to pre-filters takes place
inside `addPostFilterWithPreFilterIfRewritePossible` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
