clintropolis opened a new pull request, #13943:
URL: https://github.com/apache/druid/pull/13943
### Description
This PR fixes a join query planning regression caused by #13902. After that
change, this query will actually plan "correctly" but then later explode due to
duplicate join prefix. The planner was selecting a join prefix only looking at
the `RowSignature` of the left and right side datasources, but if those queries
had any nested join prefixes, the query would later fail because the native
prefix checker flattens the join to check prefixes (so losing the context of
what is used directly in outside layers).
The solution Ive added is to just dig through the datasources to extract any
existing prefixes and add that to the checked set when selecting new prefixes,
to ensure the planner never picks duplicate prefixes even if it can't see them
at the top level.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
