kfaraz commented on code in PR #13967:
URL: https://github.com/apache/druid/pull/13967#discussion_r1146052745
##########
server/src/main/java/org/apache/druid/client/BrokerServerView.java:
##########
@@ -265,29 +281,67 @@ private QueryableDruidServer removeServer(DruidServer
server)
return clients.remove(server.getName());
}
+ private void polledSegmentsFromCoordinator(final
ImmutableSortedSet<SegmentWithOvershadowedStatus>
segmentWithOvershadowedStatusSet) {
Review Comment:
This class does not know whether the segments were obtained via polling or
otherwise. We just need to clarify what we intend to do with those segments.
Please rename the other variables and also the callback method accordingly.
```suggestion
private void addHandedOffSegmentsToTimeline(final
ImmutableSortedSet<SegmentWithOvershadowedStatus> allPublishedSegments) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
