clintropolis commented on code in PR #13803:
URL: https://github.com/apache/druid/pull/13803#discussion_r1146904360
##########
processing/src/main/java/org/apache/druid/segment/UnnestStorageAdapter.java:
##########
@@ -101,7 +101,7 @@ public Sequence<Cursor> makeCursors(
Cursor retVal = cursor;
ColumnCapabilities capabilities =
cursor.getColumnSelectorFactory().getColumnCapabilities(dimensionToUnnest);
if (capabilities != null) {
- if
(capabilities.isDictionaryEncoded().and(capabilities.areDictionaryValuesUnique()).isTrue())
{
+ if (!capabilities.isArray() &&
capabilities.isDictionaryEncoded().and(capabilities.areDictionaryValuesUnique()).isTrue())
{
Review Comment:
i confirmed that this doesn't impact `MV_TO_ARRAY` when used in SQL because
the planner unwraps it leaving just a direct column access for the underlying
multi-value column, so the capabilities are `STRING` typed with
`hasMultipleValues` set to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
